fix(connector): extract dynamic route field as raw JSON string#3256
fix(connector): extract dynamic route field as raw JSON string#3256Standing-Man wants to merge 2 commits into
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Standing-Man
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3256 +/- ##
=============================================
- Coverage 73.84% 18.03% -55.81%
Complexity 943 943
=============================================
Files 1193 1191 -2
Lines 108970 94715 -14255
Branches 85985 71745 -14240
=============================================
- Hits 80471 17085 -63386
- Misses 25764 77238 +51474
+ Partials 2735 392 -2343
🚀 New features to boost your workflow:
|
|
@EdgarModesto23 mind taking a look at this one? it's iceberg-related. thanks! |
|
Hello @Standing-Man . Thank you for your contribution! I left a message on the original issue with some concerns I have. TL;DR: I haven't been able to reproduce the issue described. If you'd like to, I prepared a repository that can help you test this end-to-end and see the difference between master and your changes. If you do, please make sure to post your results here! I'll be more than glad to approve your changes if you find it's affecting master as described |
Hi @EdgarModesto23, Thank you for the review and for preparing the test repository! If you could share some guidance on how to test this issue end-to-end, that would be very helpful for me. I’ll compare the behavior between master and my changes and post the results here. It would also be very helpful for me if you could provide detailed steps to reproduce this issue. I’ll use them to compare the behavior between master and my changes and post the results here. cc @atharvalade. |
3 participants
Which issue does this PR close?
Closes #3177.
Rationale
What changed?
Local Execution
AI Usage